impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior
Date Mon, 13 Mar 2017 23:22:52 GMT
Sailesh Mukil has uploaded a new patch set (#2).

Change subject: IMPALA-5041: Calling AuthManager::Init() more than once results in undefined
behavior
......................................................................

IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior

We use a global variable to track the completion of the
kerberos environment setup which shouldn't be the case since
we would want to re-setup the environment if we call
AuthManager::Init() with a different configuration. Currently, if
we call it again, some of our new configuration get applied,
whereas some don't.

Also, the global variable 'env_setup_complete_' was used so that
we don't set the environment twice (once for internal transport and
once for external). This patch ensures that it's still the case.

Change-Id: I12cc210aa422f077446ea728ebf76921351417b0
---
M be/src/rpc/auth-provider.h
M be/src/rpc/authentication.cc
M be/src/rpc/authentication.h
3 files changed, 14 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/6333/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12cc210aa422f077446ea728ebf76921351417b0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>

Mime
View raw message