impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)
Date Mon, 13 Mar 2017 22:50:07 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6372/2/source/gflags/build.sh
File source/gflags/build.sh:

PS2, Line 33:   if [ -e CMakeLists.txt ]; then
            :     wrap cmake -DBUILD_STATIC_LIBS=ON -DCMAKE_INSTALL_PREFIX=$LOCAL_INSTALL
-DCMAKE_BUILD_TYPE=RELEASE
            :   else
            :     wrap ./configure --with-pic --prefix=$LOCAL_INSTALL
I assume the CMakeLists.txt path is for the newer version? I think it'd be cleaner to check
the PACKAGE_VERSION. If that's too hard, please leave comments so future readers have more
context.


http://gerrit.cloudera.org:8080/#/c/6372/2/source/glog/glog-0.3.4-patches/0001-Allow-glog-to-accept-a-message-listener.patch
File source/glog/glog-0.3.4-patches/0001-Allow-glog-to-accept-a-message-listener.patch:

Is this patch from a source you can reference, or is this new code that needs to be reviewed
more carefully?


http://gerrit.cloudera.org:8080/#/c/6372/2/source/glog/glog-0.3.4-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch
File source/glog/glog-0.3.4-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch:

Line 1: From ba317a0a34e6b0d475dc11b9e9ad4a044fed1b70 Mon Sep 17 00:00:00 2001
same as previous patch


-- 
To view, visit http://gerrit.cloudera.org:8080/6372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message