impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references
Date Mon, 13 Mar 2017 16:53:09 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6352/1/docs/impala.ditamap
File docs/impala.ditamap:

PS1, Line 301: " for
> flagging this in case you want to remove it.
Done


http://gerrit.cloudera.org:8080/#/c/6352/1/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

PS1, Line 252: DOCS-677
> not a CDH ref but I thought this would've been removed in a previous gerrit
Since the DOCS- prefix is not so prominent the way 'CDH' or 'Cloudera' are, we haven't included
removing that in our exit criteria. I see there are still a few instances. To avoid pulling
more files into this review, I'm going to leave all those as-is for now.


http://gerrit.cloudera.org:8080/#/c/6352/1/docs/topics/impala_perf_hdfs_caching.xml
File docs/topics/impala_perf_hdfs_caching.xml:

PS1, Line 84: setup_h
I may as well change this prefix so this 'cdh' doesn't show up in our grep report.


-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message