impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
Date Sun, 12 Mar 2017 07:29:13 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 2:

(23 comments)

Doing these on Saturday because Sunday is Red Hot Chili Peppers concert.

http://gerrit.cloudera.org:8080/#/c/6345/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 319: <xref keyref="sg_hive_sql"/>
> Shouldn't this be "sg_hive_sql"? Here's an excerpt from the impala_keydefs_
Done


PS1, Line 3110: If your cluster is running an older release that has this restriction,
              :         use an alternative JDBC driver that supports
              :         both of these security features.
> This is confusing. Try chunking this up into two sentences. For example: "I
I'll flip around the parts of the sentence a bit more.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

PS1, Line 1293: 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
              : 
> Could this verbiage be deleted since it is commented out? It would reduce c
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

PS1, Line 1346: <title>Issues Fixed in <keyword keyref="impala228"/></title>
> The "Impala 2.2.8" was dropped from the heading in the rendered docs (both 
Done. Very strange that the mismatch didn't produce any build errors!


PS1, Line 1460: <title>Issues Fixed in <keyword keyref="impala227"/></title>
> Same thing happened to this heading--the reference to "Impala 2.2.7" was dr
Done


PS1, Line 1886: <title>Issues Fixed in <keyword keyref="impala221"/></title>
> "impala221" isn't defined in impala_keydefs.ditamap so it isn't showing up 
Done


PS1, Line 2088: <title>Issues Fixed in <keyword keyref="impala2310"/></title>
> "impala2310" not defined in keydefs ditamap so dropped from rendered docs.
Done


PS1, Line 2098: <title>Issues Fixed in <keyword keyref="impala217"/></title>
> "impala217" not defined in keydefs ditamap so dropped from rendered docs.
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS1, Line 816: /
> Trailing forward slash should be removed from heading. Shows up in rendered
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 2153: ty-related SQL statements work along w
> This value is not present in the keydefs ditamap, so it was dropped out the
Done


PS1, Line 2373: >GRANT</codeph> and <codeph>REVOKE</co
> Same thing happened here. This value is not present in the keydefs ditamap 
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_odbc.xml
File docs/topics/impala_odbc.xml:

PS1, Line 62: xref keyref="odbc_driver_
> The URL that this points to in the keydefs ditamap 404's.
Done


PS1, Line 101: Cloudera-ODBC-Driver-for-Impala-Install-Guide.pdf
> Could this proprietary reference be removed?
That's a weird case because that's what comes with the driver. Let's leave these references
alone for now and check with Greg.


PS1, Line 104: ClouderaImpalaODBC.dmg
> Could this proprietary reference be removed?
Ditto, leaving alone for the moment.


PS1, Line 112: Cloudera ODBC Driver for Impala Install Guide.pdf
> Could this proprietary reference be removed?
Ditto.


PS1, Line 129: Sample Cloudera Impala DSN=Cloudera ODBC Driver for Impala
> Could this proprietary reference be removed?
Ditto.


PS1, Line 131: Sample Cloudera Impala DSN
> Could this proprietary reference be removed?
Ditto.


PS1, Line 138: cloudera/impalaodbc/lib/universal/libcloudera
> Could these proprietary references be removed?
Ditto.


PS1, Line 170: cloudera
> Could this proprietary reference be removed?
Ditto.


PS1, Line 182: cloudera
> Could this proprietary reference be removed?
Ditto.


PS1, Line 209: conref="../shared/impala_common.xml#common/jdbc_odbc_complex_types
> This conref'd content contains a proprietary reference to "Cloudera."
I'll take the word "Cloudera" out of the references to the names, but that might be a bad
idea as those are the official names.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_perf_stats.xml
File docs/topics/impala_perf_stats.xml:

PS1, Line 129: Where practical,
> "Cloudera recommends" reference.
Done


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

PS1, Line 419: xref keyref="archive_root
> You need to provide link text, else the URL (containing proprietary referen
Done. Suppressing the visible 'cloudera' doesn't help with the grep counting method though,
because it's still present in the HTML <a href=...> tag.


-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message