impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
Date Sat, 11 Mar 2017 00:44:40 GMT
Laurel Hale has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Phase 2 of genericizing cloudera.com links
......................................................................


Patch Set 1:

(23 comments)

Most of the issues were caused with inconsistencies in the referenced to the keydef ditamap
or missing keydef/keyref references. Needs another patch set to +1.

http://gerrit.cloudera.org:8080/#/c/6345/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 319: <xref keyref="sg_hive_sql.xml"/>
Shouldn't this be "sg_hive_sql"? Here's an excerpt from the impala_keydefs_ditamap:

<keydef href="" scope="external" format="html" keys="sg_hive_sql">
    <topicmeta><linktext>the documentation for Apache Sentry</linktext></topicmeta>
  </keydef>


PS1, Line 3110: If your cluster is running an older release that has this restriction,
              :         to use both of these security features with Impala through a JDBC
application,
              :         use the Cloudera JDBC Connector as the JDBC driver.
This is confusing. Try chunking this up into two sentences. For example: "If your cluster
is running an older release that has this restriction, use Kerberos and SSL with Impala through
a JDBC application. Then use the appropriate JDBC Connector as the JDBC driver." This makes
it more "grokable" and removes the proprietary reference.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

PS1, Line 1293: <row>
              : <entry>CREATE EXTERNAL TABLE</entry>
              : <entry>ALL, SELECT</entry>
              : <entry>Database (ALL), URI (SELECT)</entry>
              : </row>
              : <row>
              : <entry>SELECT</entry>
              : <entry>SELECT</entry>
              : <entry rev="2.3.0 collevelauth">Table, View; you can have SELECT privilege
for a view without having SELECT privilege
              : for the underlying tables. See
              : <xref keyref="sg_hive_sql"/>
              : for details about column-level authorization.
              : Before column-level authorization was added in <keyword keyref="impala23_full"/>
the way to implement
              : column-level security was by creating views that referenced particular sets
of columns.</entry>
              : </row>
              : <row>
              : <entry>USE</entry>
              : <entry>Any privilege</entry>
              : <entry>Any object in the database</entry>
              : </row>
              : <row rev="1.2">
Could this verbiage be deleted since it is commented out? It would reduce clutter and complexity.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

PS1, Line 1346: <title>Issues Fixed in <keyword keyref="impala228"/></title>
The "Impala 2.2.8" was dropped from the heading in the rendered docs (both html & pdf).
When I looked in the impala_keydefs.ditamap, I see that it's missing from there. You must
define "impala228" there.


PS1, Line 1460: <title>Issues Fixed in <keyword keyref="impala227"/></title>
Same thing happened to this heading--the reference to "Impala 2.2.7" was dropped in the rendered
doc (both html & pdf). Same as previous keyref, there is no definition for "impala227"
in impala_keydefs.ditamap.


PS1, Line 1886: <title>Issues Fixed in <keyword keyref="impala221"/></title>
"impala221" isn't defined in impala_keydefs.ditamap so it isn't showing up in the heading
of rendered docs. (html & pdf)


PS1, Line 2088: <title>Issues Fixed in <keyword keyref="impala2310"/></title>
"impala2310" not defined in keydefs ditamap so dropped from rendered docs.


PS1, Line 2098: <title>Issues Fixed in <keyword keyref="impala217"/></title>
"impala217" not defined in keydefs ditamap so dropped from rendered docs.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS1, Line 816: /
Trailing forward slash should be removed from heading. Shows up in rendered doc (both html
& pdf)


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 2153: impala_authorization.xml#authorization
This value is not present in the keydefs ditamap, so it was dropped out the of rendered docs
completely (both html & pdf). Sentence in rendered docs is, "See for details."


PS1, Line 2373: impala_authorization.xml#authorization
Same thing happened here. This value is not present in the keydefs ditamap so reference was
completely dropped in the rendered doc (both html & pdf). Sentence in rendered doc reads,
"See for details."


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_odbc.xml
File docs/topics/impala_odbc.xml:

PS1, Line 62: xref keyref="3mDesWddUS">
The URL that this points to in the keydefs ditamap 404's.


PS1, Line 101: Cloudera-ODBC-Driver-for-Impala-Install-Guide.pdf
Could this proprietary reference be removed?


PS1, Line 104: ClouderaImpalaODBC.dmg
Could this proprietary reference be removed?


PS1, Line 112: Cloudera ODBC Driver for Impala Install Guide.pdf
Could this proprietary reference be removed?


PS1, Line 129: Sample Cloudera Impala DSN=Cloudera ODBC Driver for Impala
Could this proprietary reference be removed?


PS1, Line 131: Sample Cloudera Impala DSN
Could this proprietary reference be removed?


PS1, Line 138: cloudera/impalaodbc/lib/universal/libcloudera
Could these proprietary references be removed?


PS1, Line 170: cloudera
Could this proprietary reference be removed?


PS1, Line 182: cloudera
Could this proprietary reference be removed?


PS1, Line 209: conref="../shared/impala_common.xml#common/jdbc_odbc_complex_types
This conref'd content contains a proprietary reference to "Cloudera."


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_perf_stats.xml
File docs/topics/impala_perf_stats.xml:

PS1, Line 129: <ph rev="upstream">Cloudera</ph> recommends
"Cloudera recommends" reference.


http://gerrit.cloudera.org:8080/#/c/6345/1/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

PS1, Line 419: xref keyref="archive_root
You need to provide link text, else the URL (containing proprietary reference) displays in
the rendered doc (html & pdf).


-- 
To view, visit http://gerrit.cloudera.org:8080/6345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e29c0feec7bd8e974d8a3d1eb84abe757514be7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message