impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode
Date Sat, 11 Mar 2017 00:43:22 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4996: Single-threaded KuduScanNode

Patch Set 2:


I started reviewing this and realized there are maybe some more changes you're still working
on to share the KuduClient per-query, so I'll hold off on looking much more closely. Looks
good so far though.
Commit Message:

Line 1: Parent:     def5355a (IMPALA-3403: [DOCS] Pare back irrelevant installation info)
nit: can you wrap lines in git commits at 60 chars? formatting in git tools prefer this

If you edit commit messages with git you can have it auto set this w/ this in your vimrc:

au FileType gitcommit set tw=60
File be/src/exec/

PS2, Line 122: Base
remove Base for the debugging output
File be/src/exec/kudu-scan-node.h:

PS2, Line 79: 
            :   RuntimeProfile::Counter* kudu_round_trips_;
            :   RuntimeProfile::Counter* kudu_remote_tokens_;
            :   static const std::string KUDU_ROUND_TRIPS;
            :   static const std::string KUDU_REMOTE_TOKENS;
remove; aren't these in the base class?
File tests/query_test/

PS2, Line 102: rlies

PS2, Line 118: # Parquet filtering test rlies on a specific mt_dop value, so keep in its own
update comment

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e4593300e376bc508b78acaea64ffdd2c73a67a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message