impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Date Fri, 10 Mar 2017 22:25:33 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

Line 229: Status AdmissionController::Init(StatestoreSubscriber* subscriber) {
> I'm worried about this approach for admission control. This will work when 
Ah, so the admission controller should be initialized in a 'executor-only' kind of mode if
this flag is set, and still publish its load? Makes sense. Perhaps the admission controller
should be hoisted into ExecEnv as well so that it can be initialized independently of the
scheduler.


-- 
To view, visit http://gerrit.cloudera.org:8080/6344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message