impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test
Date Fri, 10 Mar 2017 21:55:09 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6301/3//COMMIT_MSG
Commit Message:

Line 9: The tests for dictionary filtering look at how many row groups are processed and
> long lines
Done


http://gerrit.cloudera.org:8080/#/c/6301/3/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

Line 571:         (function, field, expected_value, actual_value))
> I think we should dump the complete actual profile as well for better debug
Added the profile to the dump.


-- 
To view, visit http://gerrit.cloudera.org:8080/6301
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b7b84d973b3ac678a24e82900f2637d569158bb
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message