impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Date Fri, 10 Mar 2017 21:54:03 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................


Patch Set 3:

(5 comments)

I think this info is now a reasonable compromise between removing vendor-specific info but
keeping the necessary details to make it useful for a user of the open source project.

http://gerrit.cloudera.org:8080/#/c/6008/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:

Line 49:           <p>
> I'd point to README.md. Also, this line is very long.
Done


Line 49:           <p>
> This comment has not been addressed.
Done


PS1, Line 50: 
> Does anyone do this for anything except their test minicluster?
Done


PS1, Line 50: 
> I do not know, this is not something I engage in. Who wrote the original su
That would have been me, way back in the day, using a single-node VM. Let's take it as a given
that those original "manual" instructions are sufficient, except for the part about downloading
new packages, and I'll restore that portion of the instructions.


PS1, Line 50: 
> No idea. If this is not the appropriate procedure, what is? Should I bring 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message