impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5039: Fix variability in parquet dictionary filtering test
Date Fri, 10 Mar 2017 02:11:25 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6301/2/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

Line 537:   for expected_line in expected_lines:
> You can think of each of these as sparse lists of mutually exclusive things
Thanks, make sense. Works for me.


http://gerrit.cloudera.org:8080/#/c/6301/3/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

Line 571:         (function, field, expected_value, actual_value))
I think we should dump the complete actual profile as well for better debugging.


-- 
To view, visit http://gerrit.cloudera.org:8080/6301
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b7b84d973b3ac678a24e82900f2637d569158bb
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message