impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable
Date Fri, 10 Mar 2017 02:05:43 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4008: Don't bake fields into generated IR functions of OldHashTable
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/6263/1//COMMIT_MSG
Commit Message:

Line 16: 
> I did a grep for CastPtrToLlvmPtr() to make sure there were no other instan
I looked at that instance at ScalarFnCall(). It t should be fine for MT as Expr objects are
shared across fragment instances. My understanding of that path is that it's a fall back to
the interpretation path if codegen fails for a child expression so they aren't dead code but
I think there are other ways of generating those code without cross-compiling the static stub
functions in expr-ir.cc


http://gerrit.cloudera.org:8080/#/c/6263/1/be/src/exec/hash-table-ir.cc
File be/src/exec/hash-table-ir.cc:

Line 26: ExprContext* const* HashTableCtx::GetBuildExprCtxs() const {
> Long lines
Done


http://gerrit.cloudera.org:8080/#/c/6263/1/be/src/exec/hash-table.cc
File be/src/exec/hash-table.cc:

Line 736: 
> Comment that this is pointer to the first ExprContext* pointer?
Done


Line 1099:     BasicBlock* null_block = BasicBlock::Create(context, "null", *fn);
> Maybe comment that this is a pointer to the first ExprContext*?
Done


Line 1121:     CodegenAnyVal result = CodegenAnyVal::CreateCallWrapped(codegen, &builder,
> No longer accurate
It's still accurate in a way but I rephrased it to:

expr_ctx = ctx_vector[i];


http://gerrit.cloudera.org:8080/#/c/6263/1/be/src/exec/old-hash-table.cc
File be/src/exec/old-hash-table.cc:

Line 325:       llvm_loc = builder.CreatePointerCast(llvm_loc,
> Remove TODO if you're not going to do this in this patch?
Done. old-hash-table's day is numbered anyway.


Line 651: 
> What do you think about adding a CallFunction() helper to LlvmCodegen to ma
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6263
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75500827dff56b1fa9e5296e8e8d8667ab54aef8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message