impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Date Thu, 09 Mar 2017 22:16:05 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3586: Implement union passthrough

Patch Set 13:

File be/src/exec/

Line 156:         // It is OK to close the child here because all RowBatches have already
... because all tuple data has been copied, and we will not be calling ...

Line 174:     child_batch_.reset();
move this before ++child_idx_ to have them clustered?
File be/src/exec/union-node.h:

Line 67:   /// Children that can be passed through, without evaluating and materializing their
single line

Line 109:   inline bool AtEos(int per_fragment_instance_idx) const {
Maybe it's clearer to make GetNextPassThrough() not set eos, and instead have all the *eos
setting be done directly inside GetNext(). That way each place different place can do the
appropriate checks.

Line 119:     DCHECK_LE(child_idx_, children_.size());
Checking of the child_idx_ is dependent on the aller pattern of advancing the child_idx_ and
calling into this AtEos(), another argument for maybe inlining the checks into GetNext() to
make this subtle point less disconnected.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message