impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4929: Safe concurrent access to IR function call graph
Date Thu, 09 Mar 2017 21:35:02 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-4929: Safe concurrent access to IR function call graph
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6326/2/be/src/codegen/codegen-callgraph.h
File be/src/codegen/codegen-callgraph.h:

Line 57:   bool inited_;
Maybe this is a bit overkill, but moving this (and the Init() function) to a nested class
that only allows access to the map through a const reference (returned by .get()) would make
it impossible to mutate the map after initialization, and the compiler will catch you at it
if you try.


-- 
To view, visit http://gerrit.cloudera.org:8080/6326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acd6bad80341121c8189d817e0fe62f2862f28a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message