impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()
Date Thu, 09 Mar 2017 17:57:54 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6328/1/be/src/exec/parquet-column-readers.cc
File be/src/exec/parquet-column-readers.cc:

Line 802:     bool success = stream_->GetBytes(
> We use this pattern when things are retryable (e.g. in a lot of spilling co
I was able to confirm that - it traces back to this commit. 

commit e0920e82e85b90d5b435c1afa1533dedc93c08e5
Author: Nong Li <nong@cloudera.com>
Date:   Thu Oct 11 22:57:28 2012 -0700

    Sequence file performance improvements.


-- 
To view, visit http://gerrit.cloudera.org:8080/6328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message