impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()
Date Thu, 09 Mar 2017 17:33:51 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5055: Fix DCHECK in parquet-column-readers.cc ReadPageHeader()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6328/1//COMMIT_MSG
Commit Message:

Line 13: I verified that the other uses of status are ok. Most do not check status.ok()
I think we should change GetBytes() to always initialize status. The function comment even
seems vague on this, so we should update it, too.

Does any of the other uses rely on the fact that status does not get changed if no error occurs?
If so, I think we should revisit that code.


-- 
To view, visit http://gerrit.cloudera.org:8080/6328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a8cf6b53f507c378c2efe302482409935184e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message