impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().
Date Thu, 09 Mar 2017 16:34:45 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr().
......................................................................


Patch Set 2:

> > Since I got the +1 from Zoltan, and I'd classify the subsequent
 > > suggestions as nice-to-have but not essential, any objection to
 > my
 > > +2'ing it now and revisiting improvements later?
 > 
 > Yes. The way things work on the code side is that all comments are
 > addressed before submitting.

TO be even more specific: on the code side, all comments are addressed in the opinion of reviewer,
not the patch author.

-- 
To view, visit http://gerrit.cloudera.org:8080/5589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi+gerrit@cloudera.com>
Gerrit-Reviewer: zi+zicl@cloudera.com
Gerrit-HasComments: No

Mime
View raw message