impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4957: Don't crash Impalad on LLVM fatal error
Date Wed, 08 Mar 2017 22:28:34 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4957: Don't crash Impalad on LLVM fatal error
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6318/4/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 148:   llvm::install_fatal_error_handler(LlvmCodegenHandleError);
> And even if LLVM is not in a sane state, I believe it would still allow a u
I think you're right in many cases, but they could possible have cleanup logic that we'd bypass
by throwing an exception.

One example I found is WriteBitcodeToFile(), which stack-allocates a BitstreamWriter object,
which has some assertions in the destructor that would be violated if it did an early exit.
One of it's callees calls       report_fatal_error("Unexpected anonymous function when writing
summary");

I agree in some situations that attempting recovery is better than crashing Impala. In some
situations though it may be better to fail hard and restart Impala to get to a known-good
state.

One compromise would be to have a white list of errors where we feel reasonably confident
it's safe to attempt recovery from.


-- 
To view, visit http://gerrit.cloudera.org:8080/6318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54706e261ed223eadde347b1184fb0102e03a3d6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message