impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4957: Don't crash Impalad on LLVM fatal error
Date Wed, 08 Mar 2017 21:53:22 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4957: Don't crash Impalad on LLVM fatal error
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6318/4/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 148:   llvm::install_fatal_error_handler(LlvmCodegenHandleError);
> I'm looking at the LLVM docs and it doesn't seem like there's any guarantee
It's good that you raised this concern. Isn't most if not all states confined to the LLVM
module though ? Are there particular things which may be not be sane after the fatal error
?

I will try to do an audit of all callsites for report_fatal_error().

A high level comment is that we should aim to make LLVM's error recoverable (e.g. malloc failure)
or it'll become a major hinderance for Impala's reliability in the long run.


-- 
To view, visit http://gerrit.cloudera.org:8080/6318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54706e261ed223eadde347b1184fb0102e03a3d6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message