impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section
Date Wed, 08 Mar 2017 19:22:00 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3405: [DOCS] Pare down upgrading section
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6008/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:

Line 278
> I'm not aware of the situation of these working or not working, so I'm not 
I do not have the details. I assumed you removed them because you knew they were wrong.

This patch should probably not be submitted until we have someone who knows how to do this
vet this change.


Line 49:         <xref href="https://cwiki.apache.org/confluence/display/IMPALA/Building+Impala"
scope="external" format="html">build procedure on the Apache Impala wiki</xref>.
> I'd point to README.md. Also, this line is very long.
This comment has not been addressed.


PS1, Line 50: start-impala-cluster.py
> No idea. If this is not the appropriate procedure, what is? Should I bring 
I do not know, this is not something I engage in. Who wrote the original sudo service lines
- do they know?


-- 
To view, visit http://gerrit.cloudera.org:8080/6008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41f34772200b22d176cf41a7e7ecedc3f3904b6a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message