impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4957: Don't crash Impalad on LLVM fatal error
Date Wed, 08 Mar 2017 18:44:13 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4957: Don't crash Impalad on LLVM fatal error
......................................................................


Patch Set 2:

(1 comment)

Yes, working on a backend test for it now. I validated this change by intentionally not materializing
functions and I verified the output in Impalad.INFO and Impalad.ERROR.

http://gerrit.cloudera.org:8080/#/c/6318/2/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

PS2, Line 110: [[noreturn]] 
> Is noreturn valid for functions that throw??
As far as I understand, yes.

http://en.cppreference.com/w/cpp/language/attributes:

Indicates that the function does not return. 
This attribute applies to function declarations only. The behavior is undefined if the function
with this attribute actually returns. 
The following standard functions have this attribute: std::_Exit, std::abort, std::exit, std::quick_exit,
std::unexpected, std::terminate, std::rethrow_exception, std::throw_with_nested, std::nested_exception::rethrow_nested


-- 
To view, visit http://gerrit.cloudera.org:8080/6318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54706e261ed223eadde347b1184fb0102e03a3d6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message