impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Date Wed, 08 Mar 2017 18:38:13 GMT
John Russell has posted comments on this change.

Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................


Patch Set 1:

(25 comments)

Addressed all comments.

http://gerrit.cloudera.org:8080/#/c/6267/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 3382: TSB-168
> Remove.
Done


PS1, Line 3407: udience="Cloudera
> Might want to take out the entire section here.
Because it's a CM thing I'm leaving it alone for the moment to avoid merge conflicts with
Laurel's stuff.


PS1, Line 3408: OPSAPS-26483
> Remove.
Same as above.


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala.xml
File docs/topics/impala.xml:

> This file didn't get picked up in the build. The build didn't contain any "
It is a high-level topic that's only displayed in the context of the CDH library, with everything
else grouped underneath it. These same conrefs are used elsewhere too, so there's not any
content missing in the upstream docs. I'm not going to worry about it being superfluous for
the moment, just going to make sure the Cloudera-specific references are gone from our grep
report.


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_compute_stats.xml
File docs/topics/impala_compute_stats.xml:

PS1, Line 508: CDH-19187
> CDH jira.
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_create_function.xml
File docs/topics/impala_create_function.xml:

PS1, Line 54: CDH-39148
> It looks like none of the references to CDH jira numbers were removed from 
Done. I was focusing on the CDH version numbers, which are more of a factor because they're
visible in the output, but now that you got me started I'll do these invisible references
to JIRAs also.


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

PS1, Line 691: CDH-19187
> CDH jira.
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_drop_function.xml
File docs/topics/impala_drop_function.xml:

PS1, Line 54: CDH-39148
> CDH jira - several scattered references across this topic.
Done


PS1, Line 112: cdh570.j
> make jar name generic.
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

Line 88:     <title>Issues Fixed in Impala for CDH 5.8.3</title>
> Why have this section if it is going to be empty?
We can reconstruct the history and make links to JIRA reports as a subsequent step. Probably
after JIRA migration is finished so we can use the final final URLs. For now I mainly care
about reducing the number of Cloudera-specific references.


PS1, Line 251: CDH 5.7.4
> Will you be replacing all the CDH version numbers in the titles?
Yes. Requires adding some new items in impala_keydefs.ditamap.


PS1, Line 282: CDH 5.7.0 / Impala 2.5.0
> Replace with keyref.
Done


PS1, Line 283: https://issues.cloudera.org
> do we need to change these links or can we rely on the redirects once we mi
We'll rely on redirects for the moment, and replace once we have the new URLs in place to
test.


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS1, Line 144: CDH-43734
> CDH jira - other occurrences in this topic as well.
Done


PS1, Line 1318: impala-lzo-cdh4
> Is it impossible to remove this reference?
I'll change the wording to avoid mentioning the precise package name.


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:

PS1, Line 356: CDH
> Don't "CDH" references like this fall into the cleanup categories of this p
Done


PS1, Line 589: TSB-168
> TSB jira.
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_load_data.xml
File docs/topics/impala_load_data.xml:

PS1, Line 245: CDH-19187
> CDH jira.
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:

PS1, Line 75: eyword keyref="impala225"
> Your replacement mechanism works great!
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 582: CDH-33310
> CDH jiras and references to CDH x.x / Impala x.x in this topic.
I have a sinking feeling that I'm doing some of these changes for the second time and it'll
result in a merge conflict. But let's see.

Also I'm removing some hidden or otherwise stale or inappropriate info that doesn't make sense
to genericize (e.g. DSSD certification).


PS1, Line 1343: CDH
> Still 19 CDH references showing up in the built docs.
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_prereqs.xml
File docs/topics/impala_prereqs.xml:

Line 55:   <concept id="product_compatibility_matrix">
> We could either delete this whole section, or copy the Impala table from th
Deleting for the moment.


PS1, Line 94: CDH 5 platforms
> We need to unhide the list of supported OSs since we can't point them to a 
I'm going to fix links to CDH docs in a subsequent pass and will address this issue then.


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

PS1, Line 62:  CDH-41184
> CDH jira.
Done


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_s3.xml
File docs/topics/impala_s3.xml:

PS1, Line 219: CDH-39913 
> CDH jira
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message