impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Date Wed, 08 Mar 2017 18:02:35 GMT
Hello Lars Volker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6316

to look at the new patch set (#3).

Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................

IMPALA-5044: test infra: remove backports.tempfile

backports.tempfile is not compatible with Python 2.6, so if Python 2.6
is the Python used for end-to-end tests, this test unconditionally
fails.  Moreover, Py.test provides a builtin tmpdir fixture with
equivalent functionality. Remove the requirement and port tests using
backports.tempfile.TemporaryDirectory to use tmpdir.

Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
---
M infra/python/deps/requirements.txt
M tests/query_test/test_insert_parquet.py
2 files changed, 7 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/6316/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message