impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Date Wed, 08 Mar 2017 06:16:09 GMT
Tim Armstrong has submitted this change and it was merged.

Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................


IMPALA-4711: clarify is_null semantics in udf.h

This is to reduce the chance of confusion about what the UDF interface
guarantees. E.g. I've seen users post code that assumes that the len
field of a NULL StringVal is 0, which we do not guarantee.

Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Reviewed-on: http://gerrit.cloudera.org:8080/6311
Tested-by: Impala Public Jenkins
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
---
M be/src/udf/udf.h
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message