impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4711: clarify is null semantics in udf.h
Date Wed, 08 Mar 2017 02:28:26 GMT
Hello Michael Ho,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6311

to look at the new patch set (#2).

Change subject: IMPALA-4711: clarify is_null semantics in udf.h
......................................................................

IMPALA-4711: clarify is_null semantics in udf.h

This is to reduce the chance of confusion about what the UDF interface
guarantees. E.g. I've seen users post code that assumes that the len
field of a NULL StringVal is 0, which we do not guarantee.

Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
---
M be/src/udf/udf.h
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/6311/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b3fe0b3e57f055682fa93a4ea3c20490058450b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message