impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Date Wed, 08 Mar 2017 01:07:28 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................


IMPALA-5038: Fix file size regex to include bytes

There is a regex to remove file sizes from test logs to avoid diffs
caused by changes in file headers, etc. The regex was detecting
size=number correctly, but it does not include the byte unit (i.e.
size=900B is distinct from size=900KB). A file size change introduced
by IMPALA-4624 caused a diff because the file size changed from 900B
to 1.1KB. This fixes the regex to include the byte unit, so that
changes of this form do not cause diffs.

Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Reviewed-on: http://gerrit.cloudera.org:8080/6288
Reviewed-by: Marcel Kornacker <marcel@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Marcel Kornacker: Looks good to me, approved
  Impala Public Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message