impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Date Tue, 07 Mar 2017 20:39:01 GMT
Hello Marcel Kornacker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6288

to look at the new patch set (#2).

Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................

IMPALA-5038: Fix file size regex to include bytes

There is a regex to remove file sizes from test logs to avoid diffs
caused by changes in file headers, etc. The regex was detecting
size=number correctly, but it does not include the byte unit (i.e.
size=900B is distinct from size=900KB). A file size change introduced
by IMPALA-4624 caused a diff because the file size changed from 900B
to 1.1KB. This fixes the regex to include the byte unit, so that
changes of this form do not cause diffs.

Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
---
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/6288/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message