impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Date Tue, 07 Mar 2017 20:20:15 GMT
Laurel Hale has posted comments on this change.

Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................


Patch Set 1:

(6 comments)

Most of this looks great, but I was a little confused about your intended scoping and about
one of the included topics not showing up in the build. However, it did build html & pdf
without throwing any errors.

http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala.xml
File docs/topics/impala.xml:

This file didn't get picked up in the build. The build didn't contain any "impala.html." Is
that expected behavior?


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

Shouldn't many of these CDH references have been removed as part of "Remove material related
to big lists of CDH fixed JIRAs."? Maybe I don't understand the scoping?


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS1, Line 1318: impala-lzo-cdh4
Is it impossible to remove this reference?


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:

PS1, Line 356: CDH
Don't "CDH" references like this fall into the cleanup categories of this patch?


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:

PS1, Line 75: eyword keyref="impala225"
Your replacement mechanism works great!


http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 1343: CDH
Still 19 CDH references showing up in the built docs.


-- 
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message