impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
Date Tue, 07 Mar 2017 20:07:47 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Phase 6 of "Cloudera Manager" removal
......................................................................


Patch Set 2:

(2 comments)

Please switch the 2 instances of conflict resolution where material that I removed entirely
was brought back. All the other changes look good.

http://gerrit.cloudera.org:8080/#/c/6083/2/docs/topics/impala_faq.xml
File docs/topics/impala_faq.xml:

PS2, Line 46: <concept id="faq_eval">
            : 
            :     <title>Trying Impala</title>
Looks like conflict was resolved the wrong way. At the end of the day, this page should just
have the "under construction" paragraph.


http://gerrit.cloudera.org:8080/#/c/6083/2/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

PS2, Line 1420: <concept id="incompatible_changes_07">
This is another case where I removed a block of content, and the right way to resolve the
conflict is to leave the content gone. I took out all the "Incompatible Changes" subtopics
prior to Impala 1.0.


-- 
To view, visit http://gerrit.cloudera.org:8080/6083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a5ae82ee5adfd1e2f250bc4dc26e45047dc434c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message