impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup
Date Tue, 07 Mar 2017 04:11:27 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: Fix a potential crash in Frontend & Catalog JNI startup
......................................................................


Fix a potential crash in Frontend & Catalog JNI startup

Bug: In the startup of the Frontend and the Catalog JVMs, we
incorrectly use a local reference that can potentially be
GC'ed by the JVM. Any usage of that reference can result in
an undefined behavior or a JVM crash.

Fix: In GetThriftBackendGflags(), don't push the current JNI
env into a local frame as that might GC the local references
once SerializeThriftMsg() returns.

Testing:  We can reliably reproduce this crash with the dynamic
log levels patch [1] in the following backend tests which start
multiple Frontend instances in parallel.

- buffered-block-mgr-test
- buffered-tuple-stream-test
- buffer-pool-test

With this patch, all the above tests pass.

[1] https://gerrit.cloudera.org/#/c/5792/

Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
Reviewed-on: http://gerrit.cloudera.org:8080/6264
Reviewed-by: Bharath Vissapragada <bharathv@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/util/backend-gflag-util.cc
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Bharath Vissapragada: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message