impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup
Date Mon, 06 Mar 2017 23:20:08 GMT
Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6264

to look at the new patch set (#4).

Change subject: Fix a potential crash in Frontend & Catalog JNI startup
......................................................................

Fix a potential crash in Frontend & Catalog JNI startup

Bug: In the startup of the Frontend and the Catalog JVMs, we
incorrectly use a local reference that can potentially be
GC'ed by the JVM. Any usage of that reference can result in
an undefined behavior or a JVM crash.

Fix: In GetThriftBackendGflags(), don't push the current JNI
env into a local frame as that might GC the local references
once SerializeThriftMsg() returns.

Testing:  We can reliably reproduce this crash with the dynamic
log levels patch [1] in the following backend tests which start
multiple Frontend instances in parallel.

- buffered-block-mgr-test
- buffered-tuple-stream-test
- buffer-pool-test

With this patch, all the above tests pass.

[1] https://gerrit.cloudera.org/#/c/5792/

Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
---
M be/src/util/backend-gflag-util.cc
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6264/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>

Mime
View raw message