impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4734: Set parquet::RowGroup::sorting columns
Date Mon, 06 Mar 2017 22:32:39 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4734: Set parquet::RowGroup::sorting_columns
......................................................................


Patch Set 2:

(2 comments)

Thanks for the review, I addressed the open comments in PS3. I will rebase next.

http://gerrit.cloudera.org:8080/#/c/6219/2/fe/src/main/java/org/apache/impala/planner/TableSink.java
File fe/src/main/java/org/apache/impala/planner/TableSink.java:

Line 92:    * forwarded to the backend to populate the RowGroup::sorting_columns list in parquet
> no need to comment on intention of backend here
Done


Line 97:       boolean overwrite, boolean inputIsClustered, List<Integer> sortByColumns)
{
> also add notnull checks for the lists, then
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42aab585e9e627796e9510e783652d49d74b56c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message