impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Add historical version for breakpad
Date Mon, 06 Mar 2017 21:31:23 GMT
Lars Volker has posted comments on this change.

Change subject: Add historical version for breakpad
......................................................................


Patch Set 1:

> Is this needed? I had talked to Tim recently about removing
 > HISTORICAL given we never build with it and all the version history
 > is stored in git.

I added this purely for consistency with the rest of the toolchain. Removing HISTORICAL altogether
sounds good to me, too.

-- 
To view, visit http://gerrit.cloudera.org:8080/6271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If886893532dbb2fa746d8b30ebd6619eda7c2d01
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message