impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup
Date Mon, 06 Mar 2017 19:10:15 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: Fix a potential crash in Frontend & Catalog JNI startup
......................................................................


Patch Set 3:

(1 comment)

>If you get rid of the local frame, do you still need to promote to a global ref?

I thought about it and ran the full core test suite without promoting it to global refs and
it passed. I still retained the code just to be on a safer side as I don't fully understand
the life cycle of these references. Anyway, I'm not too strong about it. Removing it from
PS3.

http://gerrit.cloudera.org:8080/#/c/6264/2//COMMIT_MSG
Commit Message:

PS2, Line 9: Fronten
> typo
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message