impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup
Date Mon, 06 Mar 2017 18:19:48 GMT
Henry Robinson has posted comments on this change.

Change subject: Fix a potential crash in Frontend & Catalog JNI startup
......................................................................


Patch Set 2:

(1 comment)

If you get rid of the local frame, do you still need to promote to a global ref?

cfg_bytes is (presumably?) allocated in the local frame of the JVM environment that is active
when GetThriftBackendGflags() is called, and that frame should still be active during the
call to the frontend / catalog c'tors.

http://gerrit.cloudera.org:8080/#/c/6264/2//COMMIT_MSG
Commit Message:

PS2, Line 9: Frotend
typo


-- 
To view, visit http://gerrit.cloudera.org:8080/6264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message