impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup
Date Mon, 06 Mar 2017 17:26:55 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: Fix a potential crash in Frontend & Catalog JNI startup
......................................................................


Patch Set 2:

Thanks for the quick review Henry. I'm no expert in JNI either but I totally agree with your
point. Also looking through the backend-gflag-util.cc, I too think there is no need to explicitly
call pushLocalFrame() since it will eventually be GC'ed anyway. That probably makes this patch
logic more deterministic. Thoughts? (updated PS2 with this change, let me know if you disagree).

> Maybe try forcing a GC after GetThriftBackendGflags() to see if the reference is collected?

Not totally sure if we can force a GC on the JVM. Per my understanding it is only a hint and
only runs when the JVM actulal want to do it.

-- 
To view, visit http://gerrit.cloudera.org:8080/6264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message