impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.
Date Mon, 06 Mar 2017 05:06:32 GMT
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Removing 'Cloudera Manager' from upstream docs.
......................................................................


Patch Set 3:

(9 comments)

Please review these so we can get them pushed to master

http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:

PS2, Line 224:  Although the Impala admission control feature uses a <codeph>fair-scheduler.xml</codeph>
configuration file
             :         behind the scenes, this file does not depend on which scheduler is
used for YARN.
> Should we duplicate content or only hide the sentence/phrase with Cloudera 
John's strategy was to hide the content in this pass and rewrite to NOT use "Cloudera Manager"
and then the hidden content will be taken care of in a subsequent clean up task.


Line 654:           To configure admission control, use a combination of startup options for
the Impala daemon and edit
> add comma; the sentence left behind reads awkwardly -- you could probably r
Rewrote to:
<p>
          To configure admission control, use a combination of startup options for the Impala
daemon and edit
          or create the configuration files <filepath>fair-scheduler.xml</filepath>
and
            <filepath>llama-site.xml</filepath>.
        </p>


PS2, Line 717: ing the 
> After hiding the CM section, you're left with only 1 example. 
Done


http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_noncm_installation.xml
File docs/topics/impala_noncm_installation.xml:

PS2, Line 109: (For CDH 4, this is a different repository than for CDH.)
> I think you can delete this.
John asked me to confine my changes to only scrubbing for references to Cloudera Manager.
Other proprietary references will be handled in subsequent "scrub" tasks.


Line 140:           <ph rev="upstream">Cloudera</ph> recommends that you not install
Impala on any HDFS NameNode. Installing Impala on NameNodes
> hide?
John asked me to confine my changes to only scrubbing for references to Cloudera Manager.
Other proprietary references will be handled in subsequent "scrub" tasks.


http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_prereqs.xml
File docs/topics/impala_prereqs.xml:

Line 86:         <indexterm audience="hidden">software requirements</indexterm>
> Explicitly list the supported OSs. They were originally hidden because we w
John asked me to confine my changes to only scrubbing for references to Cloudera Manager.
Other proprietary references will be handled in subsequent "scrub" tasks.


PS2, Line 93: The relevant supported operating systems
            :         and versions for Impala are the same as for the corresponding CDH 5
> Remove or hide this sentence.
John asked me to confine my changes to only scrubbing for references to Cloudera Manager.
Other proprietary references will be handled in subsequent "scrub" tasks.


http://gerrit.cloudera.org:8080/#/c/6064/2/docs/topics/impala_tutorial.xml
File docs/topics/impala_tutorial.xml:

Line 58:     <ul>
> assorted references to CDH and CM quickstart in this list.
John asked me to confine my changes to only scrubbing for references to Cloudera Manager.
Other proprietary references will be handled in subsequent "scrub" tasks.


Line 134: Copyright (c) 2012 Cloudera, Inc. All rights reserved.
> Remove references to cloudera from all the code samples. Several scattered 
John asked me to confine my changes to only scrubbing for references to Cloudera Manager.
Other proprietary references will be handled in subsequent "scrub" tasks.


-- 
To view, visit http://gerrit.cloudera.org:8080/6064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76c9b53f587bc85c5c21e195f0a771183d4ef3a0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message