impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add min / max to histograms
Date Sun, 05 Mar 2017 02:58:26 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: Add min / max to histograms
......................................................................


Add min / max to histograms

Even 99.9th %-ile measurements can hide a single huge outlier. Add the
min and max measurements to histogram metrics.

Add a test to metrics-test to sanity check histogram measurements.

Change-Id: Ibffd1250a4c9cda91e0cbb1b9b3a9c53df1668fe
Reviewed-on: http://gerrit.cloudera.org:8080/6257
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/util/histogram-metric.h
M be/src/util/metrics-test.cc
2 files changed, 36 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibffd1250a4c9cda91e0cbb1b9b3a9c53df1668fe
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message