impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT
Date Sat, 04 Mar 2017 02:05:29 GMT
Zach Amsden has uploaded a new patch set (#2).

Change subject: IMPALA-4318:  Kudu support for CREATE EXTERNAL TABLE AS SELECT
......................................................................

IMPALA-4318:  Kudu support for CREATE EXTERNAL TABLE AS SELECT

No reason not to allow this.  Rather than change the thrift
protocol, in the catalog executor, we detect if a table creation is
new by inferring that from the presence of column definitions, not
by whether it is external / managed.  Front-end code is changed to
allow this through the parser.

Testing: Manual testing.  I could appreciate some pointers as to
where to find the additional unit tests to modify.  ParserTest
coverage for these cases is pretty marginal, that at least should
be threshed out a bit more but I am not sure what else.

Ran the folowing query:

create external table test10_name primary key(id) partition by hash(id)
partitions 10 stored as kudu as select * from test_name;

Which successfully created and inserted 3 rows of data.  Tried a few
other things like changing primary key and partitioning, which all
seemed to work.

Update: less confusing name

Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
5 files changed, 20 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/6261/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message