impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [native-toolchain-CR] Fix setup / download order in build scripts
Date Fri, 03 Mar 2017 22:55:32 GMT
Lars Volker has submitted this change and it was merged.

Change subject: Fix setup / download order in build scripts

Fix setup / download order in build scripts

We need to download package sources before setting up the build
environment for package builds. The naming of the 'header' function made
it sound like it could be called before downloading the sources. This
change fixes the places where the order was wrong and renames the header
function to setup_package_build to make its name less confusing.

Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
M source/autoconf/
M source/automake/
M source/avro/
M source/binutils/
M source/boost/
M source/breakpad/
M source/bzip2/
M source/cmake/
M source/crcutil/
M source/cyrus-sasl/
M source/flatbuffers/
M source/gcc/
M source/gdb/
M source/gflags/
M source/glog/
M source/googletest/
M source/gperftools/
M source/gtest/
M source/kudu/
M source/libev/
M source/libevent/
M source/libtool/
M source/libunwind/
M source/llvm/
M source/llvm/
M source/llvm/
M source/lz4/
M source/openldap/
M source/openssl/
M source/protobuf/
M source/python/
M source/rapidjson/
M source/re2/
M source/snappy/
M source/thrift/
M source/tpc-ds/
M source/tpc-h/
M source/zlib/
40 files changed, 190 insertions(+), 182 deletions(-)

  Lars Volker: Looks good to me, approved; Verified

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message