impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4593,IMPALA-4635: fix some python build issues
Date Fri, 03 Mar 2017 22:42:43 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6218/2/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:

Line 115:   if cc is not None: env["CC"] = cc
Else bail with a proper error message? What's the consequence of possibly using the OS CC
here?


Line 129:   # --no-cache-dir is used to prevent caching of compiled artifacts, which may be
built
thank you!


Line 189:     LOG.debug("Skipping compiled deps: cc not available")
What's the use case for continuing here as opposed to throwing an error.


Line 326:   if install_compiled_deps_if_possible():
Are these only needed for Kudu? If so consider only doing this when KUDU_IS_SUPPORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/6218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e807510eddeb354069e0478363f649a1c1b75cf
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message