impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Fix setup / download order in build scripts
Date Fri, 03 Mar 2017 21:37:18 GMT
Hello Matthew Jacobs, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6249

to look at the new patch set (#4).

Change subject: Fix setup / download order in build scripts
......................................................................

Fix setup / download order in build scripts

We need to download package sources before setting up the build
environment for package builds. The naming of the 'header' function made
it sound like it could be called before downloading the sources. This
change fixes the places where the order was wrong and renames the header
function to setup_package_build to make its name less confusing.

Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
---
M build-kudu-only.sh
M functions.sh
M source/autoconf/build.sh
M source/automake/build.sh
M source/avro/build.sh
M source/binutils/build.sh
M source/boost/build.sh
M source/breakpad/build.sh
M source/bzip2/build.sh
M source/cmake/build.sh
M source/crcutil/build.sh
M source/cyrus-sasl/build.sh
M source/flatbuffers/build.sh
M source/gcc/build.sh
M source/gdb/build.sh
M source/gflags/build.sh
M source/glog/build.sh
M source/googletest/build.sh
M source/gperftools/build.sh
M source/gtest/build.sh
M source/kudu/build.sh
M source/libev/build.sh
M source/libevent/build.sh
M source/libtool/build.sh
M source/libunwind/build.sh
M source/llvm/build-3.3.sh
M source/llvm/build-source-tarball.sh
M source/llvm/build.sh
M source/lz4/build.sh
M source/openldap/build.sh
M source/openssl/build.sh
M source/protobuf/build.sh
M source/python/build.sh
M source/rapidjson/build.sh
M source/re2/build.sh
M source/snappy/build.sh
M source/thrift/build.sh
M source/tpc-ds/build.sh
M source/tpc-h/build.sh
M source/zlib/build.sh
40 files changed, 190 insertions(+), 182 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/49/6249/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message