impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Fix setup / download order in build scripts
Date Fri, 03 Mar 2017 20:48:07 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Fix setup / download order in build scripts
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

lgtm, let's see if Tim had any other thoughts

http://gerrit.cloudera.org:8080/#/c/6249/3/functions.sh
File functions.sh:

PS3, Line 104: prepare
not for now or related to this change, but at some point we should come back and document
more of this, and have some description somewhere of how all of these functions are intended
to be used. It's hard to understand right now outside of looking at existing examples :/


-- 
To view, visit http://gerrit.cloudera.org:8080/6249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message