impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Fix setup / download order in build scripts
Date Fri, 03 Mar 2017 20:28:43 GMT
Lars Volker has posted comments on this change.

Change subject: Fix setup / download order in build scripts
......................................................................


Patch Set 1:

(1 comment)

Thanks for the review, please see PS3.

http://gerrit.cloudera.org:8080/#/c/6249/1/functions.sh
File functions.sh:

PS1, Line 238: # Usage: footer <package name> <package version>
             : function footer() {
> just realized this now makes even less sense. maybe we should rename this l
Good point, I changed it. I added a comment to the function, too, but it wasn't entirely clear
to me what it does.


-- 
To view, visit http://gerrit.cloudera.org:8080/6249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I287f091c8e772c08c8a61644d08117145b1ef16d
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message