impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2020: Inline big number strings
Date Fri, 03 Mar 2017 04:43:26 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2020: Inline big number strings
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5902/12/be/src/runtime/decimal-value.inline.h
File be/src/runtime/decimal-value.inline.h:

Line 42:   // This means the multiplication can cause an unwanted decimal overflow.
> <slight facepalm>
What does this mean in terms of regressions when decimal_v2=false? Will we incorrectly overflow
too soon now?  Or was the old code not overflowing soon enough?  Or something different?


-- 
To view, visit http://gerrit.cloudera.org:8080/5902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message