impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT
Date Fri, 03 Mar 2017 04:25:31 GMT
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6226

to look at the new patch set (#4).

Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT
......................................................................

IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

TINYINT and SMALLINT types use 1 and 2 byte slots respectively. However,
statistics for the corresponding INT_8 and INT_16 Parquet types are
encoded using 4 bytes. When reading back we were missing a conversion
to the smaller types, thus overwriting the memory behind them. This was
caught by the address sanitizer. The fix is to perform the necessary
conversion.

Change-Id: I9b10508db53747e7b08c8bd9a69c763b82135a78
---
M be/src/exec/parquet-column-stats.cc
M be/src/runtime/coordinator.cc
2 files changed, 26 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/6226/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b10508db53747e7b08c8bd9a69c763b82135a78
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message