impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables
Date Fri, 03 Mar 2017 02:51:05 GMT
Matthew Jacobs has posted comments on this change.

Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables
......................................................................


Patch Set 3:

Thanks, Thomas. I think the overall approach makes sense. I haven't gone through and left
detailed comments yet, but I think it's reasonable to keep going along this path, e.g. supporting
other DML statements, commenting, tests, etc.

Will this end up adding an exchange node if there wasn't one before (i.e. that's what we expect)?
I guess that might happen because the partitioning exprs get set, though it wasn't obvious
in DistributedPlanner. Updating the planner tests would help.

-- 
To view, visit http://gerrit.cloudera.org:8080/6037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10b3295159354888efcde3df76b0edb24161515
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message