impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Update parameter order in test mt dop.py
Date Thu, 02 Mar 2017 23:31:22 GMT
Alex Behm has posted comments on this change.

Change subject: Update parameter order in test_mt_dop.py
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6228/2/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:

Line 46:   def test_compute_stats(self, vector, unique_database):
I don't think the order matters, but by convention we put the vector first. It's not a bug,
but an aesthetic thing


-- 
To view, visit http://gerrit.cloudera.org:8080/6228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925711eb4d4334c179d336f6ebcc91d26ce8879c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message