impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Bump breakpad version
Date Thu, 02 Mar 2017 23:01:49 GMT
Lars Volker has posted comments on this change.

Change subject: Bump breakpad version
......................................................................


Patch Set 3: Code-Review+2 Verified+1

(2 comments)

Thank you for the review. I addressed all your comments and ran a full build.

http://gerrit.cloudera.org:8080/#/c/6213/2//COMMIT_MSG
Commit Message:

PS2, Line 7: version
> remove, not sure where 'upstream' is in this context.
Done


http://gerrit.cloudera.org:8080/#/c/6213/2/source/breakpad/make-breakpad-src-archive.sh
File source/breakpad/make-breakpad-src-archive.sh:

Line 21: # releases. This script was taken from the Apache Kudu project at
> Mention where the original is?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message