impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix parameter order in test mt dop.py
Date Thu, 02 Mar 2017 21:32:12 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Fix parameter order in test_mt_dop.py
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6228/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:

Line 46:   def test_compute_stats(self, vector, unique_database):
> The order doesn't matter, since the calls use named parameters: test...(vec
ok, it's kind of misleading to call this a fix then. can you change the text to just say this
is for consistency?


-- 
To view, visit http://gerrit.cloudera.org:8080/6228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925711eb4d4334c179d336f6ebcc91d26ce8879c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message