impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix parameter order in test mt dop.py
Date Thu, 02 Mar 2017 21:30:35 GMT
Lars Volker has posted comments on this change.

Change subject: Fix parameter order in test_mt_dop.py
......................................................................


Patch Set 1:

(1 comment)

Thanks for having a look. David, please see my reply to MJ's comment.

http://gerrit.cloudera.org:8080/#/c/6228/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:

Line 46:   def test_compute_stats(self, vector, unique_database):
> how do we know what is the 'right' order? what happens when it's not in the
The order doesn't matter, since the calls use named parameters: test...(vector=..., unique_database=...).
However this is the only place in our code base where the order is different, so I thought
we may as well fix it. Maybe it'll prevent a bug in the future when someone calls the method
from another test or so.


-- 
To view, visit http://gerrit.cloudera.org:8080/6228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I925711eb4d4334c179d336f6ebcc91d26ce8879c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message